Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add high-precision pick time support and long-phase name support #2350

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@calum-chamberlain
Copy link
Contributor

commented Mar 9, 2019

What does this PR do?

Adds support for high(er)-precision timing in Nordic pick files (closes #2348) and add support for long phase names - from the seisan manual:

Long phase names: An 8 character phase can be used in column 11-18. There is then not room for polarity information. the weight is then put into column 9. This format is recognised by HYP and MULPLT

Why was it initiated? Any relevant Issues?

Seconds can run in columns 23-28 - I misread the indexing and was reading columns 23-28 rather than 22-28. #2348 pointed out that this is used when seisan is run in "high-accuracy" mode.

Note, pick times are now written out by default in high-accuracy from obspy now. I need to confirm that seisan is always happy with this, if not then a flag option for high-accuracy should be implemented.

PR Checklist

  • Correct base branch selected? master for new features, maintenance_... for bug fixes
  • This PR is not directly related to an existing issue (which has no PR yet).
  • If the PR is making changes to documentation, docs pages can be built automatically.
    Just remove the space in the following string after the + sign: "+ DOCS"
  • If any network modules should be tested for the PR, add them as a comma separated list
    (e.g. clients.fdsn,clients.arclink) after the colon in the following magic string: "+TESTS:"
    (you can also add "ALL" to just simply run all tests across all modules)
  • All tests still pass.
  • Any new features or fixed regressions are be covered via new tests.
  • Any new or changed features have are fully documented.
  • Significant changes have been added to CHANGELOG.txt .
  • First time contributors have added your name to CONTRIBUTORS.txt .
@calum-chamberlain

This comment has been minimized.

Copy link
Contributor Author

commented Mar 11, 2019

I think it is going to make more sense to rebase this on master - master has had other nordic related updates, so to make it easier for releasing I may as well make the changes there.

@d-chambers

This comment has been minimized.

Copy link
Member

commented Mar 11, 2019

I think we are done with the 1.1.x releases anyway

@calum-chamberlain

This comment has been minimized.

Copy link
Contributor Author

commented Mar 11, 2019

I didn't rebase in the end, too many changes to handle, so I just made the small number of changes here on master and opened a new PR at #2351

@calum-chamberlain calum-chamberlain deleted the nordic_high_precision branch Mar 11, 2019

@megies megies added the duplicate label Mar 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.