Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segy nice error message when trying to write traces with too many samples #2358

Open
wants to merge 2 commits into
base: master
from

Conversation

2 participants
@megies
Copy link
Member

megies commented Mar 15, 2019

What does this PR do?

Handles and closes #1393.

PR Checklist

  • Correct base branch selected? master for new features, maintenance_... for bug fixes
  • This PR is not directly related to an existing issue (which has no PR yet).
  • If the PR is making changes to documentation, docs pages can be built automatically.
    Just remove the space in the following string after the + sign: "+ DOCS"
  • If any network modules should be tested for the PR, add them as a comma separated list
    (e.g. clients.fdsn,clients.arclink) after the colon in the following magic string: "+TESTS:"
    (you can also add "ALL" to just simply run all tests across all modules)
  • All tests still pass.
  • Any new features or fixed regressions are be covered via new tests.
  • Any new or changed features have are fully documented.
  • Significant changes have been added to CHANGELOG.txt .
  • First time contributors have added your name to CONTRIBUTORS.txt .

@megies megies added the .io.segy label Mar 15, 2019

@megies megies added this to the 1.2.0 milestone Mar 15, 2019

@megies megies force-pushed the segy_nice_error_msg branch from 3ff6141 to f7e2324 Mar 15, 2019

@megies megies added this to Waiting on CI in Release 1.2.0 Mar 15, 2019

@megies megies force-pushed the segy_nice_error_msg branch from f7e2324 to b098dbe Mar 15, 2019

@megies megies self-assigned this Mar 15, 2019

@megies

This comment has been minimized.

Copy link
Member Author

megies commented Mar 15, 2019

Hrmm.. the new message for number of samples is overwriting the more generic message about any header field failing to get packed. I still think we should have this special message since this is likely the error encountered most often but I don't know how to change the test for the generic header packing fail which also uses the npts case...

Anybody can think of a header packing fail that is easy to test and is not about npts or sampling_rate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.