Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with a newline between blockettes #2383

Merged
merged 2 commits into from Apr 15, 2019

Conversation

Projects
None yet
2 participants
@krischer
Copy link
Member

krischer commented Apr 12, 2019

This deals with an extremely rare edges where there are extra newlines characters between blockettes. I'm not even sure this is valid SEED but F-Net serves some of these files and in my testing it does not hurt our ability to read other SEED files.

@krischer krischer added the .io.xseed label Apr 12, 2019

@krischer krischer added this to the 1.2.0 milestone Apr 12, 2019

@krischer krischer requested a review from megies Apr 12, 2019

@megies

This comment has been minimized.

Copy link
Member

megies commented Apr 15, 2019

FYI rdseed shows the same error message

$ rdseed   
<< IRIS SEED Reader, Release 4.6  >>
Input  File (/dev/nrst0) or 'Quit' to Exit: dataless.seed.newline_between_blockettes
Output File (stdout)	: 
Volume #  [(1)-N]	: 
Options [acCsSpRtde]	: 
WARNING (process_volh):  unknown blockette type 1 found in record 1.
	Execution continuing.

PDCC seems to read the file after showing a warning:

WARNING: encountered odd character where expecting blockette type: '
'.
LOCATION: 
0110021001MANZ 000003                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                     
CORRECTION: retry reading SEED record, byte shifted by one.
@megies

megies approved these changes Apr 15, 2019

Copy link
Member

megies left a comment

I guess this is a workaround for files breaching the SEED conventions, but looks like it won't hurt in case of good files.

@krischer

This comment has been minimized.

Copy link
Member Author

krischer commented Apr 15, 2019

Thanks for the review. It is true that these are not valid files but I also cannot imagine a scenario where this can hurt our ability to read valid files.

@krischer krischer merged commit 3f4a592 into master Apr 15, 2019

1 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
docker-testbot docker testbot results not available yet
ci/circleci Your tests passed on CircleCI!
Details

@krischer krischer deleted the seed-edge-case branch Apr 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.