Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build_taup_model for model with no discontinuity #2390

Open
wants to merge 1 commit into
base: master
from

Conversation

3 participants
@not522
Copy link

commented Apr 26, 2019

What does this PR do?

This PR fixes build_taup_model for the no discontinuity model. If the structure model has no first order discontinuity, v_layer in create_from_vlayer can be 1-D empty array.

Why was it initiated? Any relevant Issues?

This PR fixes #2086 and fixes #2192.

PR Checklist

  • Correct base branch selected? master for new features, maintenance_... for bug fixes
  • This PR is not directly related to an existing issue (which has no PR yet).
  • If the PR is making changes to documentation, docs pages can be built automatically.
    Just remove the space in the following string after the + sign: "+ DOCS"
  • If any network modules should be tested for the PR, add them as a comma separated list
    (e.g. clients.fdsn,clients.arclink) after the colon in the following magic string: "+TESTS:"
    (you can also add "ALL" to just simply run all tests across all modules)
  • All tests still pass.
  • Any new features or fixed regressions are be covered via new tests.
  • Any new or changed features have are fully documented.
  • Significant changes have been added to CHANGELOG.txt .
  • First time contributors have added your name to CONTRIBUTORS.txt .
@krischer

This comment has been minimized.

Copy link
Member

commented Apr 26, 2019

Thanks for this! Can you please rebase on top of the latest master and also change the target branch to master? ObsPy 1.1.x is done. Please let me know if you need help with that!

@krischer krischer self-requested a review Apr 26, 2019

@krischer krischer self-assigned this Apr 26, 2019

@krischer krischer added this to the 1.2.0 milestone Apr 26, 2019

@megies

This comment has been minimized.

Copy link
Member

commented May 15, 2019

Thanks for this! Can you please rebase on top of the latest master and also change the target branch to master? ObsPy 1.1.x is done. Please let me know if you need help with that!

Ping @not522

Also, you need to also add the expected phase arrivals in the test, currently this is not being tested because zip stops when one of the lists is exhausted.

@megies megies added this to In Progress in Release 1.2.0 May 15, 2019

@not522 not522 changed the base branch from maintenance_1.1.x to master May 16, 2019

@not522

This comment has been minimized.

Copy link
Author

commented May 16, 2019

Sorry for the late reply. I'm trying to test the phase arrivals for the new case, but it fails due to other bugs. I'm working to fix them. It will take time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.