Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Rotate stream to uvw #1992 and #2372 #2397
This pull request adds a method to stream.rotate so that streams can be rotated from any coordinates to UVW coordinates. It also fixes an issue in stream.rotate where previously if stream.rotate failed, the stream would be emptied, this has been adjusted so that if there is an error, the stream is not returned empty.
This pull request was initiated to fix issues #1992 and #2372 so that it will be possible to use stream.rotate to rotate to UVW coordinates, and so that if an error occurs while a stream is being rotated it is not emptied.
@megies I rebased and fixed the circleci problems in the files that I had changed, the circleci test is still failing so should I go through and fix problems in the other files that weren't me? I wasn't sure if doing that might cause more issues