Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix polarization issues #2403

Merged
merged 3 commits into from May 24, 2019

Conversation

Projects
None yet
1 participant
@megies
Copy link
Member

commented May 22, 2019

What does this PR do?

Fixes #2365

Why was it initiated? Any relevant Issues?

See #2365

PR Checklist

  • Correct base branch selected? master for new features, maintenance_... for bug fixes
  • This PR is not directly related to an existing issue (which has no PR yet).
  • If the PR is making changes to documentation, docs pages can be built automatically.
    Just remove the space in the following string after the + sign: "+ DOCS"
  • If any network modules should be tested for the PR, add them as a comma separated list
    (e.g. clients.fdsn,clients.arclink) after the colon in the following magic string: "+TESTS:"
    (you can also add "ALL" to just simply run all tests across all modules)
  • All tests still pass.
  • Any new features or fixed regressions are be covered via new tests.
  • Any new or changed features have are fully documented.
  • Significant changes have been added to CHANGELOG.txt .
  • First time contributors have added your name to CONTRIBUTORS.txt .

Can you please double-check @sjohnson5?

megies added some commits May 22, 2019

polarization: add some sanity checks on given stream and raise on
problematic input data that will give erratic results or raise strange
messages later on anyway

@megies megies added the .signal label May 22, 2019

@megies megies added this to the 1.2.0 milestone May 22, 2019

@megies

This comment has been minimized.

Copy link
Member Author

commented May 24, 2019

Reviewed by the person that reported the bug in #2365, so merging..

@megies megies merged commit eef3a0f into master May 24, 2019

1 of 5 checks passed

continuous-integration/appveyor/branch AppVeyor build failed
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
docker-testbot docker testbot results not available yet
ci/circleci Your tests passed on CircleCI!
Details

@megies megies deleted the fix_polarization_issues branch May 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.