Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nordic: Add support for AIN:takeoff_angle #2404

Merged
merged 3 commits into from Jun 12, 2019

Conversation

Projects
None yet
2 participants
@calum-chamberlain
Copy link
Contributor

commented May 24, 2019

What does this PR do?

This PR turns on reading AIN from Nordic files to takeoff_angle (and writing the reverse) and turns off the warnings.

Why was it initiated? Any relevant Issues?

It turns out I misunderstood what AIN was (angle of incidence), I wrongly assumed it was angle of incidence at the seismometer, but it is in fact takeoff angle. As this is supported in quakeml and Events I thought I should read it.

This PR is created on master because lots of changes have been made in master to nordic IO that are not in maintenance_1.1.x. This isn't really a feature though.

PR Checklist

  • Correct base branch selected? master for new features, maintenance_... for bug fixes
  • This PR is not directly related to an existing issue (which has no PR yet).
    - [ ] If the PR is making changes to documentation, docs pages can be built automatically.
    Just remove the space in the following string after the + sign: "+ DOCS"

    - [ ] If any network modules should be tested for the PR, add them as a comma separated list
    (e.g. clients.fdsn,clients.arclink) after the colon in the following magic string: "+TESTS:"
    (you can also add "ALL" to just simply run all tests across all modules)
  • All tests still pass.
  • Any new features or fixed regressions are be covered via new tests.
  • Any new or changed features have are fully documented.
  • Significant changes have been added to CHANGELOG.txt .
    - [ ] First time contributors have added your name to CONTRIBUTORS.txt .

calum-chamberlain added some commits May 24, 2019

@megies megies changed the title Add support for AIN:takeoff_angle nordic: Add support for AIN:takeoff_angle May 24, 2019

@megies

megies approved these changes May 24, 2019

Copy link
Member

left a comment

One minor comment, otherwise looks good to go.

Show resolved Hide resolved obspy/io/nordic/tests/test_nordic.py Outdated

@megies megies added this to the 1.2.0 milestone May 24, 2019

@megies megies merged commit 61a4360 into master Jun 12, 2019

1 of 4 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
docker-testbot docker testbot results not available yet
ci/circleci Your tests passed on CircleCI!
Details

@megies megies deleted the nordic-ain branch Jun 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.