Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seishub: fix fetching paz for stations with multiple metadata files #2411

Merged
merged 1 commit into from Jun 12, 2019

Conversation

Projects
None yet
1 participant
@megies
Copy link
Member

commented Jun 12, 2019

What does this PR do?

Fix fetching poles and zeros when there are multiple metadata files on the server for a given station.

Why was it initiated? Any relevant Issues?

Before this was only looking at the first found metadata file which in many cases doesn't hold the desired response info.

PR Checklist

  • Correct base branch selected? master for new features, maintenance_... for bug fixes
  • This PR is not directly related to an existing issue (which has no PR yet).
  • If the PR is making changes to documentation, docs pages can be built automatically.
    Just remove the space in the following string after the + sign: "+ DOCS"
  • If any network modules should be tested for the PR, add them as a comma separated list
    (e.g. clients.fdsn,clients.arclink) after the colon in the following magic string: "+TESTS:"
    (you can also add "ALL" to just simply run all tests across all modules)
  • All tests still pass.
  • Any new features or fixed regressions are be covered via new tests.
  • Any new or changed features have are fully documented.
  • Significant changes have been added to CHANGELOG.txt .
  • First time contributors have added your name to CONTRIBUTORS.txt .

@megies megies added this to the 1.2.0 milestone Jun 12, 2019

@megies megies force-pushed the megies:seishub_fix_multiple_response_files branch from a50d48f to 2c26f10 Jun 12, 2019

@megies

This comment has been minimized.

Copy link
Member Author

commented Jun 12, 2019

No New tests, but existing tests still pass locally and it worked for me right now when I needed it to. Won't affect many people anyway, so merging.

@megies megies merged commit 86b3f98 into obspy:master Jun 12, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci Your tests passed on CircleCI!
Details

@megies megies deleted the megies:seishub_fix_multiple_response_files branch Jun 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.