Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize setup somewhat #2422

Open
wants to merge 6 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@QuLogic
Copy link
Member

commented Jun 28, 2019

What does this PR do?

This makes setuptools required and uses all its niceties to remove custom stuff from our setup.py. It also drops NumPy since we no longer need it. And adds a few new things that we aren't yet taking advantage of.

Why was it initiated? Any relevant Issues?

Fixes #1051.

PR Checklist

  • Correct base branch selected? master for new features, maintenance_... for bug fixes
  • This PR is not directly related to an existing issue (which has no PR yet).
  • [N/A] If the PR is making changes to documentation, docs pages can be built automatically.
    Just remove the space in the following string after the + sign: "+ DOCS"
  • [N/A] If any network modules should be tested for the PR, add them as a comma separated list
    (e.g. clients.fdsn,clients.arclink) after the colon in the following magic string: "+TESTS:"
    (you can also add "ALL" to just simply run all tests across all modules)
  • All tests still pass.
  • [N/A] Any new features or fixed regressions are be covered via new tests.
  • [?] Any new or changed features have are fully documented.
  • Significant changes have been added to CHANGELOG.txt .
  • [N/A] First time contributors have added your name to CONTRIBUTORS.txt .

check were this has to be changed

  • deb packaging
  • conda recipe on our conda-forge feedstock
  • .... ?

@megies megies added the installation label Jun 28, 2019

@QuLogic

This comment has been minimized.

Copy link
Member Author

commented Jul 1, 2019

[ ] conda recipe on our conda-forge feedstock

Already includes setuptools in host and run (I think it doesn't need to be in build too?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.