Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some Flake8 issues and assure consistency CircleCI/Builtin Test case #2453

Merged
merged 9 commits into from Sep 13, 2019

Conversation

@megies
Copy link
Member

commented Sep 13, 2019

What does this PR do?

  • fix some flake8 fails
  • assure consistency between CircleCI and ObsPy builtin code formatting test case

Why was it initiated? Any relevant Issues?

Flake8 fails on master

PR Checklist

  • Correct base branch selected? master for new features, maintenance_... for bug fixes
  • This PR is not directly related to an existing issue (which has no PR yet).
  • If the PR is making changes to documentation, docs pages can be built automatically.
    Just remove the space in the following string after the + sign: "+ DOCS"
  • If any network modules should be tested for the PR, add them as a comma separated list
    (e.g. clients.fdsn,clients.arclink) after the colon in the following magic string: "+TESTS:"
    (you can also add "ALL" to just simply run all tests across all modules)
  • All tests still pass.
  • Any new features or fixed regressions are be covered via new tests.
  • Any new or changed features have are fully documented.
  • Significant changes have been added to CHANGELOG.txt .
  • First time contributors have added your name to CONTRIBUTORS.txt .
megies added 6 commits Sep 13, 2019
…alid

closing bracket indentation according to PEP8
@megies megies added the testing label Sep 13, 2019
@megies megies added this to the 1.2.0 milestone Sep 13, 2019
megies added 3 commits Sep 13, 2019
both are valid according to PEP8 and we decided to allow both
@megies megies merged commit 837153c into master Sep 13, 2019
1 of 4 checks passed
1 of 4 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
docker-testbot docker testbot results not available yet
ci/circleci Your tests passed on CircleCI!
Details
@megies megies deleted the flake8 branch Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.