Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make interphinx point to latest python version #2454

Merged
merged 1 commit into from Sep 16, 2019

Conversation

@trichter
Copy link
Member

commented Sep 13, 2019

Intersphinx links in the docs still point to python2.7.
+DOCS

@megies megies added this to the 1.2.0 milestone Sep 13, 2019
@megies megies added the docs label Sep 13, 2019
@megies megies added this to Waiting on CI in Release 1.2.0 Sep 13, 2019
@QuLogic

This comment has been minimized.

Copy link
Member

commented Sep 14, 2019

The build succeeded with warnings, though they seem unrelated. Unfortunately, I don't know where to look to verify this didn't break anything. Anyone know somewhere we might be referencing Python types?

@trichter

This comment has been minimized.

Copy link
Member Author

commented Sep 16, 2019

Here are some references and it looks as it is working as expected.

@trichter trichter moved this from Waiting on CI to Waiting for final manual validation by Core Dev in Release 1.2.0 Sep 16, 2019
@trichter trichter merged commit 26feb5d into master Sep 16, 2019
1 of 6 checks passed
1 of 6 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/branch AppVeyor build failed
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
docs-buildbot Build succeeded, but there are warnings/errors:
Details
docker-testbot docker testbot results not available yet
ci/circleci Your tests passed on CircleCI!
Details
@trichter trichter deleted the intersphinx branch Sep 16, 2019
@trichter trichter moved this from Waiting for final manual validation by Core Dev to Done in Release 1.2.0 Sep 16, 2019
@megies

This comment has been minimized.

Copy link
Member

commented Sep 16, 2019

The build succeeded with warnings, though they seem unrelated. Unfortunately, I don't know where to look to verify this didn't break anything. Anyone know somewhere we might be referencing Python types?

Yeah, unfortunately nobody ever got around to getting rid of all Sphinx warnings, some of the Sphinx warnings are also really weird, so it's unlikely we will ever get master to a clean build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3 participants
You can’t perform that action at this time.