Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More robust ISO8601 detection + option to disable auto detection #2456

merged 4 commits into from Sep 17, 2019


Copy link

commented Sep 13, 2019

What does this PR do?

Improves ISO8601 detection

Why was it initiated? Any relevant Issues?


PR Checklist

  • Correct base branch selected? master for new features, maintenance_... for bug fixes
  • This PR is not directly related to an existing issue (which has no PR yet).
  • If the PR is making changes to documentation, docs pages can be built automatically.
    Just remove the space in the following string after the + sign: "+DOCS"
  • If any network modules should be tested for the PR, add them as a comma separated list
    (e.g. clients.fdsn,clients.arclink) after the colon in the following magic string: "+TESTS: ALL"
    (you can also add "ALL" to just simply run all tests across all modules)
  • All tests still pass.
  • Any new features or fixed regressions are be covered via new tests.
  • Any new or changed features have are fully documented.
  • Significant changes have been added to CHANGELOG.txt .
  • [N/A] First time contributors have added your name to CONTRIBUTORS.txt .
@megies megies added this to Waiting for Review in Release 1.2.0 Sep 16, 2019
obspy/core/ Outdated Show resolved Hide resolved
@megies megies added this to the 1.2.0 milestone Sep 16, 2019

This comment has been minimized.

Copy link

commented Sep 16, 2019

Should have a short changelog notice

megies approved these changes Sep 16, 2019
Copy link

left a comment

changelog missing, otherwise good to go

@megies megies merged commit b574bf4 into master Sep 17, 2019
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
continuous-integration/appveyor/pr AppVeyor build failed
ci/circleci Your tests passed on CircleCI!
@megies megies deleted the 2447 branch Sep 17, 2019
@megies megies moved this from Waiting for Review to Done in Release 1.2.0 Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.