Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basemaps: remove hard coded area_thresh #2477

Open
wants to merge 2 commits into
base: master
from

Conversation

@megies
Copy link
Member

commented Oct 9, 2019

What does this PR do?

Remove hard coded area_thresh, otherwise small land masses do not get plotted, regardless what resolution is set. basemap sets area_thresh to supposedly reasonable values depending on resolution, just rely on their defaults.

Why was it initiated? Any relevant Issues?

Fixes #2471

PR Checklist

  • Correct base branch selected? master for new features, maintenance_... for bug fixes
  • This PR is not directly related to an existing issue (which has no PR yet).
  • If the PR is making changes to documentation, docs pages can be built automatically.
    Just remove the space in the following string after the + sign: "+ DOCS"
  • If any network modules should be tested for the PR, add them as a comma separated list
    (e.g. clients.fdsn,clients.arclink) after the colon in the following magic string: "+TESTS:"
    (you can also add "ALL" to just simply run all tests across all modules)
  • All tests still pass.
  • Any new features or fixed regressions are be covered via new tests.
  • Any new or changed features have are fully documented.
  • Significant changes have been added to CHANGELOG.txt .
  • First time contributors have added your name to CONTRIBUTORS.txt .
otherwise small land masses do not get plotted, regardless what
resolution is set. basemap sets area_thresh to supposedly reasonable
values depending on resolution, just rely on their defaults
@megies megies added the .imaging label Oct 9, 2019
@megies megies added this to the 1.2.0 milestone Oct 9, 2019
@megies megies requested a review from shicks-seismo Oct 9, 2019
@megies megies added this to Waiting for Review in Release 1.2.0 Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Release 1.2.0
Waiting for Review
3 participants
You can’t perform that action at this time.