Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some minor fixes #2557

merged 8 commits into from Feb 14, 2020

Some minor fixes #2557

merged 8 commits into from Feb 14, 2020


Copy link

megies commented Feb 13, 2020

What does this PR do?

Fixes some test fails from docker runs see

Why was it initiated? Any relevant Issues?

Please fill in

PR Checklist

  • Correct base branch selected? master for new features, maintenance_... for bug fixes
  • This PR is not directly related to an existing issue (which has no PR yet).
  • If the PR is making changes to documentation, docs pages can be built automatically.
    Just remove the space in the following string after the + sign: "+ DOCS"
  • If any network modules should be tested for the PR, add them as a comma separated list
    (e.g. clients.fdsn,clients.arclink) after the colon in the following magic string: "+TESTS:"
    (you can also add "ALL" to just simply run all tests across all modules)
  • All tests still pass.
  • Any new features or fixed regressions are be covered via new tests.
  • Any new or changed features have are fully documented.
  • Significant changes have been added to CHANGELOG.txt .
  • First time contributors have added your name to CONTRIBUTORS.txt .
megies added 3 commits Feb 13, 2020
see and others

not sure why this only raises an index error on that specific machine,
we might have some inconsistencies in `Catalog.__bool__`??

e.g. centos 7 has ancient sqlalchemy
@megies megies added this to the 1.2.0 milestone Feb 13, 2020
@megies megies added this to Waiting on CI in Release 1.2.0 Feb 13, 2020
megies added 5 commits Feb 14, 2020
lxml won't parse xml from a unicode string if it includes a textual
declaration of the xml encoding. seems an easy solution is to encode to
bytes, utf-8 should work for all normal cases

see #2405
@megies megies moved this from Waiting on CI to Done in Release 1.2.0 Feb 14, 2020
@megies megies merged commit 56a3525 into master Feb 14, 2020
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
ci/circleci Your tests passed on CircleCI!
continuous-integration/appveyor/pr AppVeyor build succeeded
@megies megies deleted the minor_fixes branch Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.