Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of distutils #2952

Merged
merged 2 commits into from Jan 18, 2022
Merged

Remove use of distutils #2952

merged 2 commits into from Jan 18, 2022

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Jan 17, 2022

What does this PR do?

In main code, distutils can be dropped, as the version check is no longer necessary. In tests, it can be replaced by packaging.version.

Why was it initiated? Any relevant Issues?

distutils is deprecated and will be removed in Python 3.12.

PR Checklist

  • Correct base branch selected? master for new features, maintenance_... for bug fixes
  • This PR is not directly related to an existing issue (which has no PR yet).
  • If the PR is making changes to documentation, docs pages can be built automatically.
    Just add the "build_docs" tag to this PR.
  • If all tests including network modules (e.g. clients.fdsn) should be tested for the PR,
    just add the "test_network" tag to this PR.
  • All tests still pass.
  • Any new features or fixed regressions are covered via new tests.
  • Any new or changed features are fully documented.
  • Significant changes have been added to CHANGELOG.txt .
  • First time contributors have added your name to CONTRIBUTORS.txt .
  • If the changes affect any plotting functions you have checked that the plots
    from all the CI builds look correct. Add the "upload_plots" tag so that plotting
    outputs are attached as artifacts.
  • Add the "ready for review" tag when you are ready for the PR to be reviewed.

@QuLogic QuLogic added this to the 1.3.0 milestone Jan 17, 2022
@d-chambers
Copy link
Member

Any ideas on the windows failure in the CI?

@trichter
Copy link
Member

Could the test fail in windows be related to the changes in this PR?

@d-chambers
Copy link
Member

Could the test fail in windows be related to the changes in this PR?

Let's see if it happens again on a restart.

@d-chambers
Copy link
Member

Same failure on windows, python 3.7 after restart.

We require v1, so >=0.19 is always true.
The latter is deprecated and will be removed in Python 3.12.
@QuLogic
Copy link
Member Author

QuLogic commented Jan 18, 2022

OK, I'll drop the sysconfig commit for now, though it really should be a copy of the main one. I'll put that in #2422 instead.

@QuLogic QuLogic added the ready for review PRs that are ready to be reviewed to get marked ready to merge label Jan 18, 2022
@d-chambers d-chambers merged commit 5b7252c into obspy:master Jan 18, 2022
@QuLogic QuLogic deleted the no-distutils branch January 18, 2022 21:57
@trichter trichter removed the ready for review PRs that are ready to be reviewed to get marked ready to merge label Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants