Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: __unicode__ must return unicode #53

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dpetukhov
Copy link

Because if str(self.parent) returns something like \xd0\xbf\xd1\x80\xd0\xb8\xd0\xb2\xd0\xb5\xd1\x82 and you try to print(ModelClosure), you will get UnicodeEncodeError

I see this error in Django Admin interface on delete confirmation page when I try to delete User which has linked Comments which have CommentClosure instances saved in database. And django admin trying to show string representation of all objects and fails.

Reference:

Because if `str(self.parent)` actually returns something like `\xd0\xbf\xd1\x80\xd0\xb8\xd0\xb2\xd0\xb5\xd1\x82` and you try to `print(ModelClosure)`, you will see UnicodeEncodeError
@dpetukhov
Copy link
Author

Probably I need to add some tests to actually prove the issue and fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant