Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fluid: The fluid hx.notice.head() function uses the wrong class. #232

Closed
c-frater opened this issue Apr 27, 2016 · 0 comments
Closed

Fluid: The fluid hx.notice.head() function uses the wrong class. #232

c-frater opened this issue Apr 27, 2016 · 0 comments
Assignees
Labels

Comments

@c-frater
Copy link
Contributor

@c-frater c-frater commented Apr 27, 2016

The hx.notice.head() function creates an element with the hx-notice-head class, however the notice module uses hx-notice-header. Either the fluid api should be changes to use hx-notice-header or notice should use hx-notice-head.

In either case, adding hx-notice-head as a class for the notice module whilst retaining the existing class will make this a pre-2.0.0 change.

@c-frater c-frater added the Bug label Apr 27, 2016
@c-frater c-frater self-assigned this Jun 28, 2016
@jmsmyth jmsmyth closed this in d2514e8 Jun 28, 2016
jmsmyth added a commit that referenced this issue Jun 28, 2016
@jmsmyth jmsmyth removed the In Review label Jun 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants