New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DatePicker: validRange should be a constructor parameter #350

Closed
georgesimms opened this Issue Nov 16, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@georgesimms
Copy link
Contributor

georgesimms commented Nov 16, 2016

DatePicker: validRange should be a constructor parameter

Context

This is to make it easy to set the validRange from the fluid API, as well as from DateTimePicker

Expected Behavior

hx.datePicker({validRange: {start, end}}).component().validRange().should.equal({start, end})

Actual Behavior

hx.datePicker({validRange: {start, end}}).component().validRange().should.equal({start: undefined, end: undefined})

Possible Fix

Accept validRange as a constructor parameter

Your Environment

  • Hexagon Version: 1.8.2

  • Browser Name and version: Chromium 53.0.2785.143 Built on Ubuntu , running on Ubuntu 16.04

  • Operating System and version (desktop or mobile): Ubuntu 16.04

@c-frater c-frater added the Bug label Nov 18, 2016

@c-frater

This comment has been minimized.

Copy link
Contributor

c-frater commented Nov 18, 2016

Marked as bug - all values with a setter/getter should be available as constructor options

@c-frater c-frater added this to the Pre 2.0.0 milestone Jul 6, 2018

@c-frater c-frater self-assigned this Jul 11, 2018

@c-frater c-frater added In Review and removed In Review labels Jul 24, 2018

@c-frater c-frater closed this Jul 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment