New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InlineEditable: no way to edit empty string #351

Closed
ilya-grebtsov opened this Issue Nov 22, 2016 · 0 comments

Comments

Projects
None yet
3 participants
@ilya-grebtsov
Copy link

ilya-grebtsov commented Nov 22, 2016

If initial string is empty, it's not possible to edit it using InlineEditable component.

Context

InlineEditable component ( https://www.hexagonjs.io/docs/1.8.2/inline-editable/ ).
Hexagon version 1.8.2 and early.

Steps to Reproduce

  1. Open the help page: https://www.hexagonjs.io/docs/1.8.2/inline-editable/
  2. Click the "John Smith" string, input field is appeared.
  3. Replace "John Smith" to "" (empty string).
  4. Save the change.

Expected Behavior

When click the empty string, input field is appeared.

Actual Behavior

Nothing to click to show input field.

Possible Fix

CSS rule:

a.hx-morph-toggle {
    min-width: 1em;
    min-height: 1em;
}

Your Environment

  • Hexagon Version: 1.8.2
  • Browser Name and version: Google Chrome v54.0
  • Operating System and version (desktop or mobile): MS Windows 7

@c-frater c-frater added the Bug label Dec 14, 2016

@c-frater c-frater self-assigned this Jan 5, 2017

@c-frater c-frater added the In Progress label Jan 5, 2017

@c-frater c-frater referenced this issue Jan 5, 2017

Merged

#351 Inline editable enchancements #366

6 of 6 tasks complete

@c-frater c-frater added In Review and removed In Progress labels Jan 5, 2017

@jmsmyth jmsmyth closed this in #366 Jan 12, 2017

jmsmyth added a commit that referenced this issue Jan 12, 2017

Merge pull request #366 from ocadotechnology/#351-inline-editable-enh…
…ancements

#351 Inline editable enchancements

@jmsmyth jmsmyth removed the In Review label Jan 12, 2017

c-frater added a commit that referenced this issue Mar 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment