New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataTable: filter ignored when sorting any column in descending order #360

Closed
pkubowicz opened this Issue Dec 21, 2016 · 1 comment

Comments

Projects
None yet
4 participants
@pkubowicz
Copy link

pkubowicz commented Dec 21, 2016

Context

Users complain that my data table 'loses' filter when they sort data

Expected Behavior

Filter applies, only matching rows appear

Actual Behavior

All rows are visible

Steps to Reproduce

  1. Open https://www.hexagonjs.io/docs/1.9.0/data-table/
  2. In the first example type '41' to the filter field (you should see 2 of 3 rows)
  3. Click any column 2 times to sort it in descending order

If the demo page works correct, the regression was introduced after version 1.4.2.

Your Environment

  • Hexagon Version: 1.9.0
  • Browser Name and version: Chrome 55.0.2883.87 (64-bit) - also reproduced in Firefox 50.1.0
  • Operating System and version (desktop or mobile): Kubuntu 16.10

@c-frater c-frater added the Bug label Jan 4, 2017

c-frater added a commit that referenced this issue Jan 4, 2017

@c-frater c-frater self-assigned this Jan 4, 2017

@c-frater c-frater added the In Progress label Jan 4, 2017

@c-frater c-frater referenced this issue Jan 4, 2017

Merged

#360 data table sort bugfix #363

6 of 6 tasks complete

@c-frater c-frater added In Review and removed In Progress labels Jan 4, 2017

@tkusienicki

This comment has been minimized.

Copy link

tkusienicki commented Jan 9, 2017

It happens also when you change a page (table pagination).

@jmsmyth jmsmyth closed this in #363 Jan 12, 2017

@jmsmyth jmsmyth removed the In Review label Jan 12, 2017

jmsmyth added a commit that referenced this issue Jan 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment