New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selection: hx.select(selection) warns #376

Closed
jonthans opened this Issue Jan 17, 2017 · 0 comments

Comments

Projects
None yet
2 participants
@jonthans
Copy link
Contributor

jonthans commented Jan 17, 2017

Context

When passing a hx.Selection to a hexagon constructor like hx.Graph I get a console warning about selecting an hx.selection. It seems odd that hexagon apparently doesn't want to deal with its own objects.

Expected Behavior

hexagon shouldn't care whether you pass it a node or a selection

Actual Behavior

hexagon gives a warning when being passed a selection

@jonthans jonthans changed the title hx.select(selection) warns Selection: hx.select(selection) warns Jan 17, 2017

@jonthans jonthans self-assigned this Jan 25, 2017

jmsmyth added a commit that referenced this issue Jan 25, 2017

Merge pull request #381 from jonthans/376-select-selection-no-op
#376 stopped hx.select from warning on selecting a Selection

@jmsmyth jmsmyth closed this Jan 25, 2017

@jmsmyth jmsmyth removed the In Progress label Jan 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment