New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag Input: removing a tag with the api inconsistent to user removal #406

Closed
c-frater opened this Issue Jun 26, 2017 · 0 comments

Comments

Projects
None yet
2 participants
@c-frater
Copy link
Contributor

c-frater commented Jun 26, 2017

Context

When calling the remove method, the event is fired and then the tag selection is removed.
When clicking the 'x' on a tag, the tag selection is removed and then the event is fired.
As the tag input is using selection.text() to get the 'items' it makes it difficult to have a consistent way to detect when there are x tags left for example.

Expected Behavior

Both api and user events should happen either before or after the tag selection is removed (consitency)

Actual Behavior

api remove event for remove('name') is emit and then tag removed
api remove event for remove() is emit for each tag and then all tags are removed in one go
user remove event (for mouse click) emit after tag has been removed from dom

Possible Fix

This could be resolved several ways:

  • Use the same 'remove' function for api/user events
  • Using an array under-the-hood to set the list of tags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment