New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutocompletePicker: No events fired when clearing the value #438

Open
c-frater opened this Issue Apr 17, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@c-frater
Copy link
Contributor

c-frater commented Apr 17, 2018

Context

When setting the AutocompletePicker value to undefined the change event is not fired

Possible Fix

Updating the setPickerValue function to emit when there both is and is not a value

@c-frater c-frater added the Bug label Apr 17, 2018

@c-frater c-frater modified the milestones: 2.0.0, Pre 2.0.0 Jul 3, 2018

@c-frater c-frater self-assigned this Jul 11, 2018

@c-frater c-frater added In Review and removed In Review labels Jul 24, 2018

@c-frater c-frater closed this Jul 24, 2018

c-frater added a commit that referenced this issue Sep 4, 2018

fix(revert-438): Revert change
Reverts commit: d48811a
Reverts issue #438

@c-frater c-frater referenced this issue Sep 4, 2018

Merged

1.17.1 #509

6 of 6 tasks complete
@c-frater

This comment has been minimized.

Copy link
Contributor

c-frater commented Sep 4, 2018

Re-opening as this change was reverted in #509

@c-frater c-frater reopened this Sep 4, 2018

@c-frater c-frater modified the milestones: Pre 2.0.0, 2.0.0 Sep 12, 2018

@c-frater c-frater removed their assignment Sep 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment