New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IE support issue(s) #440

Merged
merged 27 commits into from May 10, 2018

Conversation

Projects
None yet
3 participants
@c-frater
Copy link
Contributor

c-frater commented Apr 19, 2018

Description

fix(dropdown): Use IE supported variables

IE doesn't support scrollX/scrollY - Added a fallback to pageXOffset
to allow IE to render correctly

Resolves #227
Resolves #228
Resolves #229


fix(date-picker): Fix flex behaviour to support IE

IE handles the default flex behaviour differently so we need a min-width
on the grid items.

Related to: #228 (screenshot illustrates issue)

How Has This Been Tested?

Tested in IE browser + existing tests pass

Checklist:

  • I have added a tag to this pull request that indicates the impact of the change (patch, minor or major)
  • My code follows the code style of this project.
  • I have updated the documentation accordingly. (This includes updating the changelog).
  • I have read the CONTRIBUTING document.
  • All my changes are covered by tests.
  • This request is ready to review and merge

c-frater added some commits Apr 19, 2018

fix(date-picker): Fix flex behaviour to support IE
IE handles the default flex behaviour differently so we need a min-width
on the grid items.

Related to: #228 (screenshot illustrates issue)

@c-frater c-frater self-assigned this Apr 19, 2018

@c-frater c-frater requested a review from jmsmyth Apr 19, 2018

@c-frater c-frater added the In Review label Apr 19, 2018

@coveralls

This comment has been minimized.

Copy link

coveralls commented Apr 19, 2018

Coverage Status

Coverage decreased (-0.2%) to 63.56% when pulling f1f5f4d on ie-support into a8539f2 on master.

c-frater added some commits Apr 19, 2018

fix(logo): Swap img.hx-logo for div.hx-logo
IE doesn't support `img::after` so we have to use a `div`
fix(form): Fix submit button alignment for IE
The `display: table-row` doesn't achieve anything on non-IE so removing
it makes sense
fix(file-input): Fix issue where the value was immediately cleared in IE
Calling `input.value('')` triggers the change event in IE but not newer
browsers it seems.
docs(multi): Fix assorted docs issues found whilst testing
- extended-table: Examples weren't removed in 1.0.0
- inline-select: Examples weren't removed in 1.0.0
- search-dom: : Examples weren't removed in 1.0.0
- modal: Out of order examples
- number-picker: Out of order examples
fix(multiple): Fix several flex minimum flex size issue for IE
- data-table: Filter box was small-width, advanced search wrapped text
- picker: wrapped text when used in flex parent
- modal: wrapped title oddly on smaller screens
fix(sticky-table-headers): Add tolerance to scrollbar width adjustments
The `scrollHeight` and `clientHeight` always differ by a few pixels in
IE. A reasonably sensible solution is to have a tolerance of the
scrollbar width �����for the 'has scroll' detection

@c-frater c-frater changed the title WIP: Fix IE support issue(s) Fix IE support issue(s) Apr 30, 2018

@c-frater

This comment has been minimized.

Copy link
Contributor

c-frater commented Apr 30, 2018

Before merging, we should decide whether we want to make these changes into a release on their own

c-frater added some commits May 2, 2018

Merge remote-tracking branch 'github/master' into ie-support
# Conflicts:
#	docs/content/templates/sidebar-page.um
@@js
var exampleNotificationManager = new hx.NotificationManager('#example')
hx.select('#notify').on('click', function() {
console.log('bob')

This comment has been minimized.

@jmsmyth

jmsmyth May 10, 2018

Contributor

Remove?

This comment has been minimized.

@c-frater

c-frater May 10, 2018

Contributor

Done

@@ -15,7 +15,7 @@
"private": true,
"devDependencies": {
"font-awesome": "^4.7.0",
"hexagon-js": "1.14.0",
"hexagon-js": "nextReleaseVersion",

This comment has been minimized.

@jmsmyth

jmsmyth May 10, 2018

Contributor

I guess this should be 1.14.0 still?

This comment has been minimized.

@c-frater

c-frater May 10, 2018

Contributor

Yep - forgot to change it back

@@ -0,0 +1,13 @@

replaceWithDiv = (sel) ->
replacement = hx.div('hx-logo')

This comment has been minimized.

@jmsmyth

jmsmyth May 10, 2018

Contributor

sel.replace(hx.div('hx-logo')) would also do the same

This comment has been minimized.

@c-frater

c-frater May 10, 2018

Contributor

Didn't realise replace was a thing - Changed

@@ -1,5 +1,6 @@
{
"dependencies": [
"util"

This comment has been minimized.

@jmsmyth

jmsmyth May 10, 2018

Contributor

Also relies on "selection" now

This comment has been minimized.

@c-frater

c-frater May 10, 2018

Contributor

Done

@c-frater c-frater merged commit 15db097 into master May 10, 2018

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.2%) to 63.56%
Details

@c-frater c-frater deleted the ie-support branch May 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment