Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

BatIO.input_channel should have cleanup param default to true #109

Closed
mdekstrand opened this Issue Feb 4, 2011 · 3 comments

Comments

Projects
None yet
3 participants
Contributor

mdekstrand commented Feb 4, 2011

If you need cleanup:false for BatIO.input_channel/BatInnerIO.input_channel, you're proably doing something wrong or at least very strange. The default should be true so that IO naturally cleans things up.

This is a breaking change, so it needs to wait for 2.0.

@mdekstrand mdekstrand was assigned Apr 18, 2011

Owner

thelema commented Apr 18, 2011

Is this committed to the v2.0 branch?

Contributor

mdekstrand commented Apr 19, 2011

I thought I had, but it looks like I did not.

@c-cube c-cube added a commit to c-cube/batteries-included that referenced this issue Dec 30, 2013

@c-cube c-cube small patch for #109 , with cleanup of BatIO.input enabled by default 6b70566

@c-cube c-cube added a commit to c-cube/batteries-included that referenced this issue Apr 11, 2014

@c-cube c-cube small patch for #109 , with cleanup of BatIO.input enabled by default 9be1dea
Owner

gasche commented Apr 27, 2016

Fixed by merging #671.

@gasche gasche closed this Apr 27, 2016

@gasche gasche added a commit to gasche/batteries-included that referenced this issue May 8, 2016

@c-cube @gasche c-cube + gasche small patch for #109 , with cleanup of BatIO.input enabled by default ad971aa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment