Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Documentation of raised exceptions #184

Merged
merged 11 commits into from

3 participants

@toton

Corrected some mistakes, added some missing @raise clauses.
Two commits (7215e..., a475e...) change the code to [assert false] when impossible happens (instead of raising other exceptions).
Added grep-based script for sanity checking of the documentation of exception raising.

@thelema thelema merged commit bb65d57 into from
@thelema
Owner

Very awesome! I wonder where in the process this tool should be run. If it's not in the makefile somewhere, to be run automatically at build or test, it may be forgotten about.

@gasche
Owner

Just a question on the tool (awesome indeed): why are those modules "manually excluded"? At first sight it would be better to re-check everything each time, so that future changes that would break the convention are also caught. Do those modules raise (sic) false negatives, or are there performance issues? In the first case I think we should try to have a finer-grained opt-out mechanism.

@toton
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.