Add some Format-based container pretty printers to BatIO.Incubator #292

Merged
merged 1 commit into from Sep 30, 2012

Conversation

Projects
None yet
3 participants
@hcarty
Contributor

hcarty commented Sep 27, 2012

These are not based on toplevel printer code but their output is pretty close. I've put them in Incubator in case we want to either move the location of the functions around or change the interfaces of the functions themselves.

thelema added a commit that referenced this pull request Sep 30, 2012

Merge pull request #292 from hcarty/format-printers
Add some Format-based container pretty printers to BatIO.Incubator

@thelema thelema merged commit 3c6b01e into ocaml-batteries-team:master Sep 30, 2012

@vincent-hugot

This comment has been minimized.

Show comment Hide comment
@vincent-hugot

vincent-hugot Oct 5, 2012

Member

I get a problem with 'make test' that seems linked to this (haven't done a bisect or any other troubleshooting, sorry)

+ ocamlfind ocamlc -c -g -annot -w A -w e -w -29 -package bigarray,num,str -package oUnit -thread -I testsuite -I build -I src -I qtest -I benchsuite -I libs -I src/syntax/pa_comprehension -I src/syntax/pa_strings -I libs/estring -o testsuite/test_bounded.cmo testsuite/test_bounded.ml
File "testsuite/test_bounded.ml", line 15, characters 31-41:
Error: Signature mismatch:
       Modules do not match:
         sig
           type t = int
           val bounds : [> `c of int ] * [> `c of int ]
           val default_low : 'a option
           val default_high : 'a option
           val bounded : (int, int option) BatBounded.bounding_f
         end
       is not included in
         BatBounded.BoundedType
       The field `map2' is required but not provided
       The field `map' is required but not provided
       The field `base_of_t_exn' is required but not provided
       The field `base_of_t' is required but not provided
       The field `base_t' is required but not provided
Member

vincent-hugot commented on 3a0dee8 Oct 5, 2012

I get a problem with 'make test' that seems linked to this (haven't done a bisect or any other troubleshooting, sorry)

+ ocamlfind ocamlc -c -g -annot -w A -w e -w -29 -package bigarray,num,str -package oUnit -thread -I testsuite -I build -I src -I qtest -I benchsuite -I libs -I src/syntax/pa_comprehension -I src/syntax/pa_strings -I libs/estring -o testsuite/test_bounded.cmo testsuite/test_bounded.ml
File "testsuite/test_bounded.ml", line 15, characters 31-41:
Error: Signature mismatch:
       Modules do not match:
         sig
           type t = int
           val bounds : [> `c of int ] * [> `c of int ]
           val default_low : 'a option
           val default_high : 'a option
           val bounded : (int, int option) BatBounded.bounding_f
         end
       is not included in
         BatBounded.BoundedType
       The field `map2' is required but not provided
       The field `map' is required but not provided
       The field `base_of_t_exn' is required but not provided
       The field `base_of_t' is required but not provided
       The field `base_t' is required but not provided

This comment has been minimized.

Show comment Hide comment
@hcarty

hcarty Oct 8, 2012

Contributor

This was caused by a problem in an earlier pull request. It should be fixed by a pull request I just submitted.

Contributor

hcarty replied Oct 8, 2012

This was caused by a problem in an earlier pull request. It should be fixed by a pull request I just submitted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment