Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

cutoff optional argument to batString.edit_distance #466

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Member

c-cube commented Nov 15, 2013

Yes, I know, I just implemented a cutoff argument, as proposed by @gasche :)

Owner

gasche commented Nov 15, 2013

I'm nervous about overflow problems as they were explained in my implementation; you have cutoff = max_int cases and then you work with 2 * cutoff - i...

Member

c-cube commented Nov 15, 2013

Apparently 2 * max_int - 1 is negative, so that cannot satisfy the test that "cutoff < String.length && ....". Maybe that should be documented, though, because I agree that it's not a trivial invariant. How would you handle it?

Member

c-cube commented Jan 12, 2014

I think @gasche has a more powerful implementation up his sleeve. This PR is probably useless, I'm thinking of closing it.

@c-cube c-cube closed this Apr 11, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment