small patch for #109 , with cleanup of BatIO.input enabled by default #489

Closed
wants to merge 1 commit into from

3 participants

@c-cube
ocaml-batteries-team member

couldn't comment on the issue (too old!? github bugs), so here's a patch just in case

@thelema
ocaml-batteries-team member

I'm guessing this should have been included in batteries 2.0. As this is backwards incompatible, it'll have to wait until 3.0.

@c-cube
ocaml-batteries-team member

Couldn't it be considered as a bugfix? Discussion in #109 seems to consider this behavior as wrong, and people relying on cleanup=false definitely should provide ~cleanup:false when they call the function.

@gasche
ocaml-batteries-team member

Merged in master, should be in 3.0.

@gasche gasche closed this Apr 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment