correct the following compilation warnings: #530

Open
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@UnixJunkie
Member

UnixJunkie commented Feb 4, 2014

Warning: tag "package" does not expect a parameter, but is used with parameter "oUnit"
Warning: tag "package" does not expect a parameter, but is used with parameter "QTest2Lib"

PS: we have 11 _tags file in the batteries tree, amazing...

Francois Berenger
correct the following compilation warnings:
Warning: tag "package" does not expect a parameter, but is used with parameter "oUnit"
Warning: tag "package" does not expect a parameter, but is used with parameter "QTest2Lib"
@gasche

This comment has been minimized.

Show comment Hide comment
@gasche

gasche Feb 4, 2014

I don't think the patch is correct. Does compiling the testsuite still work after this?

The problem is that some of our ocamlbuild invocation lack the -use-ocamlfind option that gives meaning to the package(X) parametrized flag, but those don't actually rely on this part of the _tags so the warning is rather benign. It's good to fix it nonetheless.

gasche commented on 3b8aed1 Feb 4, 2014

I don't think the patch is correct. Does compiling the testsuite still work after this?

The problem is that some of our ocamlbuild invocation lack the -use-ocamlfind option that gives meaning to the package(X) parametrized flag, but those don't actually rely on this part of the _tags so the warning is rather benign. It's good to fix it nonetheless.

This comment has been minimized.

Show comment Hide comment
@UnixJunkie

UnixJunkie Feb 4, 2014

Owner

I can run make test and make test-native after, at least.
But I am certainly not an ocamlbuild expert.

Owner

UnixJunkie replied Feb 4, 2014

I can run make test and make test-native after, at least.
But I am certainly not an ocamlbuild expert.

@c-cube

This comment has been minimized.

Show comment Hide comment
@c-cube

c-cube Feb 4, 2014

Member

I most likely introduced those parameters (and the warning) to have make coverage work properly. We have to make sure it still works afterwards :)

Member

c-cube commented Feb 4, 2014

I most likely introduced those parameters (and the warning) to have make coverage work properly. We have to make sure it still works afterwards :)

@UnixJunkie

This comment has been minimized.

Show comment Hide comment
@UnixJunkie

UnixJunkie Nov 16, 2015

Member

@c-cube do you manage to remove those warnings?

Member

UnixJunkie commented Nov 16, 2015

@c-cube do you manage to remove those warnings?

@gasche

This comment has been minimized.

Show comment Hide comment
@gasche

gasche Nov 16, 2015

Member

I still think that passing -use-ocamlfind in the right place(s) in the Makefile should solve these warnings without touching those tags, which look fine. I wouldn't support removing the tags just to fix warnings.

Member

gasche commented Nov 16, 2015

I still think that passing -use-ocamlfind in the right place(s) in the Makefile should solve these warnings without touching those tags, which look fine. I wouldn't support removing the tags just to fix warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment