Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a couple of issues with the display name #124

Merged
merged 2 commits into from Apr 25, 2023
Merged

Fix a couple of issues with the display name #124

merged 2 commits into from Apr 25, 2023

Conversation

punchagan
Copy link
Contributor

  • Fix the baseline value being incorrect
  • Fix the baseline value being shown as a float for values of counts

Closes #123

@punchagan
Fix the baseline value in the display name
8755014 
1468d7c incorrectly fixed an issue with
`add_display_name` where the baseline and variant having different benchmarks.

Closes ocaml-bench#123
@punchagan
Display a float or an int in the display name based on value type
ee7d038
@punchagan punchagan mentioned this pull request Apr 24, 2023
Closed
@kayceesrk
Copy link
Contributor

Thanks for the fix.

@kayceesrk kayceesrk merged commit 904b0ae into ocaml-bench:main Apr 25, 2023
1 check passed
@punchagan punchagan deleted the fix-display-name branch April 25, 2023 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shakthimaan shakthimaan Awaiting requested review from shakthimaan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Normalised major GCs display the wrong baseline counts
2 participants
@punchagan @kayceesrk