Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to latest version of domainslib and saturn #461

Merged
merged 1 commit into from Aug 1, 2023

Conversation

Sudha247
Copy link
Contributor

No description provided.

@Sudha247 Sudha247 marked this pull request as ready for review July 31, 2023 07:49
@Sudha247
Copy link
Contributor Author

Okay, good news is the CI is happy - I've marked it as ready for review. Question (to @punchagan or @shakthimaan): does the parallel runs include graph500 benchmarks? I saw some failures on it in my local setup with this PR.

@punchagan
Copy link
Contributor

Okay, good news is the CI is happy - I've marked it as ready for review. Question (to @punchagan or @shakthimaan): does the parallel runs include graph500 benchmarks? I saw some failures on it in my local setup with this PR.

Could you share the failures you see?

From the latest run in Navajo, we run graph500_gen benchmarks

@Sudha247
Copy link
Contributor Author

The log says

$ (cd _build/5.2.0+trunk_1/benchmarks/graph500seq && ./gen.exe -scale 21 -edgefactor 16 edges.data)
> Generating edge list...
[got signal KILL]
$ (cd _build/5.2.0+trunk_1/benchmarks/graph500par && ./gen.exe -scale 21 -edgefactor 16 -ndomains 16 edges.data)
> Generating edge list...
> Generated. Time: 173.464429 s.

Maybe the benchmark's just too big for my machine. It might help to do a run on navajo or another larger machine, but otherwise I don't have any other changes to this PR.

@punchagan
Copy link
Contributor

It might help to do a run on navajo or another larger machine

The changes look good to me. I'll do a test run on navajo and merge the PR. Thanks for the PR, @Sudha247!

@punchagan punchagan merged commit 4fe98f9 into ocaml-bench:main Aug 1, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants