Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions #79

Merged
merged 3 commits into from Oct 21, 2021
Merged

GitHub Actions #79

merged 3 commits into from Oct 21, 2021

Conversation

liyishuai
Copy link
Collaborator

Replacing Travis CI, which is no longer free.
The current workflow has lots of jobs. Maybe worth trimming down a few.
Tests failed on Windows.

@mjambon
Copy link
Member

mjambon commented Oct 19, 2021

Given the nature of the project, I'd err on the side of caution and test as many ocaml versions (major.minor.) as possible unless there's a major cost to doing that.

@mjambon
Copy link
Member

mjambon commented Oct 19, 2021

I have no idea about the Windows setup. It sounds like a great thing to have in theory. I just don't have the experience running anything on Windows.

@liyishuai
Copy link
Collaborator Author

I wondered if the Windows error was caused by Git's CRLF configuration, so I set autocrlf to false. Now Windows build fails at setting up OCaml:

Retrieve the Cygwin cache
Error: connect ECONNREFUSED 8.43.85.97:443

@avsm any instructions?

@pmetzger
Copy link
Member

BTW, @liyishuai, we probably need to do this for everything in ocaml-community, so if you are familiar with the needed steps, the help would be most welcome.

@liyishuai
Copy link
Collaborator Author

BTW, @liyishuai, we probably need to do this for everything in ocaml-community, so if you are familiar with the needed steps, the help would be most welcome.

The current script is quite generic up to installing the dependencies. Other projects can copy these lines and add their own build/test/deploy afterwards.

See also ocaml/setup-ocaml#117

@liyishuai
Copy link
Collaborator Author

Update: the script now tests packages that depend on cppo.

@liyishuai
Copy link
Collaborator Author

liyishuai commented Oct 21, 2021

Ready to merge. A few issues to address later:

  • Install dependants' external dependencies, to reduce false "broken dependency".
  • Unskip dependant tests for some packages, OCaml 4.02.x, and Windows.

liyishuai and others added 2 commits October 21, 2021 00:12
Co-authored-by: Erik Martin-Dorel <erik@martin-dorel.org>
@pmetzger
Copy link
Member

@liyishuai I think you should feel free to merge once you feel you're ready. And again, if you wanted to do the same (very generic) thing for other projects in ocaml-community, we would all be grateful.

@liyishuai liyishuai self-assigned this Oct 21, 2021
@liyishuai
Copy link
Collaborator Author

Yes I'll propagate the self-test part to other projects.
The dependant test script needs better polishing (maybe whitelist rather than blacklist).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants