Skip to content

Finish port to dune #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from
Aug 28, 2018
Merged

Finish port to dune #69

1 commit merged into from
Aug 28, 2018

Conversation

@ghost
Copy link

@ghost ghost commented Aug 28, 2018

  • convert the last remaining jbuild files
  • update the README

@jeremiedimino
Finish port to dune
c6c8485 
- convert the last remaining jbuild files
- update the README

Fixes #68
@pmetzger
Copy link
Member

pmetzger commented Aug 28, 2018

LGTM, though my dune fu is weak so I might have missed even obvious mistakes.

@ghost
Copy link
Author

ghost commented Aug 28, 2018

Ok. I tried the commands by hand and they worked as expected. That should be enough testing for this.

@ghost ghost merged commit 059d48a into master Aug 28, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pmetzger @jeremiedimino