Replace caml_modify_field with caml_modify #500

Sudha247 · 2021-03-17T06:00:03Z

One more patch removing historic C-functions that are not required anymore. This one replaces all usages of cam_modify_field with caml_modify and remove cam_modify_field.

ctk21

Thanks, this looks good in the whole.

One minor things:

I found one more instance of caml_modify_field in the memory model comment in memory.c; are we able to just rename that one to caml_modify as well?

ctk21 · 2021-03-18T07:42:00Z

Thanks, LGTM.

…caml_modify Replace caml_modify_field with caml_modify

caml_modify_field -> caml_modify

c32a586

ctk21 reviewed Mar 17, 2021

View reviewed changes

edit comment

021aad5

ctk21 merged commit 1db56c8 into ocaml-multicore:4.12+domains+effects Mar 18, 2021

sadiqj pushed a commit to sadiqj/ocaml that referenced this pull request Jan 10, 2022

Merge pull request ocaml-multicore/ocaml-multicore#500 from Sudha247/…

fe6e5de

…caml_modify Replace caml_modify_field with caml_modify

Replace caml_modify_field with caml_modify #500

Replace caml_modify_field with caml_modify #500

Sudha247 commented Mar 17, 2021

ctk21 left a comment •

edited

ctk21 commented Mar 18, 2021

Replace caml_modify_field with caml_modify #500

Replace caml_modify_field with caml_modify #500

Conversation

Sudha247 commented Mar 17, 2021

ctk21 left a comment • edited

Choose a reason for hiding this comment

ctk21 commented Mar 18, 2021

ctk21 left a comment •

edited