Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shorten the generated branch name #141

Merged
merged 1 commit into from Dec 14, 2022
Merged

Shorten the generated branch name #141

merged 1 commit into from Dec 14, 2022

Conversation

kit-ty-kate
Copy link
Contributor

Fixes #139

@kit-ty-kate kit-ty-kate mentioned this pull request Nov 8, 2022
Closed
@rjbou
Copy link
Contributor

rjbou commented Nov 9, 2022

Why keep the smallest instead of setting it as the org when > n chars?

@kit-ty-kate
Copy link
Contributor Author

for large orgs this wouldn't work (they would get conflicts)

@rjbou
Copy link
Contributor

rjbou commented Dec 13, 2022

maybe append with "and_x_others" like that it doesn't "lie" on PR content

@kit-ty-kate kit-ty-kate merged commit b98e144 into ocaml-opam:master Dec 14, 2022
@kit-ty-kate kit-ty-kate deleted the shorten-branch-name branch December 14, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generated user branches can be too long
2 participants
@kit-ty-kate @rjbou