Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve functor concrete syntax in the Parsetree #2345

Merged
merged 4 commits into from Apr 24, 2023

Conversation

gpetiot
Copy link
Collaborator

@gpetiot gpetiot commented Apr 21, 2023

I was reminded of the state of the functors while working on the new syntax.

This simplifies the formatting, removes the sugaring, the need to relocate comments and the need to lookup the source.

@gpetiot gpetiot added the no changelog set this to bypass the CI check for changelog entries label Apr 21, 2023
@gpetiot gpetiot requested a review from Julow April 21, 2023 18:51
@gpetiot gpetiot force-pushed the preserve-functor-concrete-syntax branch from f3550fe to 43df46c Compare April 22, 2023 05:48
Copy link
Collaborator

@Julow Julow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, LGTM!

@gpetiot gpetiot merged commit ef3c1df into ocaml-ppx:main Apr 24, 2023
9 of 10 checks passed
@gpetiot gpetiot deleted the preserve-functor-concrete-syntax branch April 24, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog set this to bypass the CI check for changelog entries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants