Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve: option nested-match=align #827

Merged
merged 4 commits into from Jun 5, 2019
Merged

Conversation

@gpetiot
Copy link
Collaborator

gpetiot commented May 13, 2019

Fix #492
No bug with test_branch (the changes are similar to those of the tests).

The change is made for nested match and try but maybe we should only make for nested match.

Copy link
Collaborator

Julow left a comment

Looks good !

src/Conf.ml Outdated Show resolved Hide resolved
src/Conf.ml Outdated Show resolved Hide resolved
@gpetiot gpetiot changed the title Improve: option nested-match=align [WIP] Improve: option nested-match=align May 13, 2019
@gpetiot gpetiot requested a review from Julow May 22, 2019
@gpetiot gpetiot changed the title [WIP] Improve: option nested-match=align Improve: option nested-match=align May 23, 2019
@Julow
Julow approved these changes May 31, 2019
Copy link
Collaborator

Julow left a comment

Looks good !

@gpetiot

This comment has been minimized.

Copy link
Collaborator Author

gpetiot commented May 31, 2019

@Khady any opinion before we merge? (especially on whether the try should be handled like match for this feature)

@Khady

This comment has been minimized.

Copy link
Contributor

Khady commented Jun 3, 2019

We don't really chain try blocks. So I don't have a strong opinion about this. The match behavior looks like what we need. Thanks!

@gpetiot gpetiot merged commit 383ccf8 into ocaml-ppx:master Jun 5, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@gpetiot gpetiot deleted the gpetiot:nested-match branch Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.