Gate inline-records-with-attributes test to >=4.03 - #204
Merged
gasche merged 1 commit intoSep 9, 2019
Merged
Conversation
Merged
Contributor
|
This looks very sensible, will merge when CI returns. The reason why the CI hasn't caught it earlier is that we don't have 4.02 CI anymore. I'm trying to fix this in #205. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing #199 on 4.02.3. Somebody should sanity-check this; it was just the simplest way for me to get the tests passing. (hi! 🙋♀️ yep, that's me, still over here being an annoyance 🤣)
Presumably, whatever feature he's adding support for is unavailable on the 4.02-series? Nonetheless, being present in the tests-file at all breaks them on 4.02.3 for me:
Let me know if this is a bad idea somehow! ❤️