Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Ensure release-please triggers docker/build-push-action jobs #443

merged 1 commit into from Oct 13, 2021


Copy link

@erikmd erikmd commented Oct 12, 2021

I tested this approach as realistically as possible in our dummy separate repo, but I guess the very test will be on the next release.
Anyway @yurug feel free to proofread this refactoring in case you'd see a typo somewhere…

* This wasn't automatic up to now because these jobs was in a separate
  workflow and the tagging or release events that occur in release.yml
  cannot trigger children workflows from a mere "secrets.GITHUB_TOKEN"

* href:
Copy link
Member Author

erikmd commented Oct 13, 2021

Hi @yurug, I've proofread the workflow code once more and everything looks fine; so squash-merging this PR.

@erikmd erikmd merged commit 71c3590 into ocaml-sf:master Oct 13, 2021
@erikmd erikmd deleted the fix-docker-ci-cd branch October 13, 2021 15:01
@erikmd erikmd added the kind: infrastructure CI, build tools, development tools label Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
kind: infrastructure CI, build tools, development tools
None yet

Successfully merging this pull request may close these issues.

None yet

1 participant