fix(pkg): remove duplication in portable lock directories#13637
Closed
Alizter wants to merge 1 commit into
Closed
Conversation
Rather than duplicating the build logic in portable lock directories for each platform, we keep around the when-conditional so that we have a more compact lock file. Signed-off-by: Ali Caglayan <alizter@gmail.com>
rgrinberg
requested changes
Feb 18, 2026
Member
rgrinberg
left a comment
rgrinberg
left a comment
There was a problem hiding this comment.
As discussed, this doesn't work well when the opam file includes values for the platform specific variables that should be eliminated. The test does not demonstrate such variables at the moment.
Collaborator
Author
|
Closing this for now. I will make a better version that enumerates the platforms and removes redundant expressions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than duplicating the build logic in portable lock directories for each platform, we keep around the when-conditional so that we have a more compact lock file.