Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Higher version number #1

Closed
dra27 opened this issue Mar 12, 2019 · 9 comments
Closed

Higher version number #1

dra27 opened this issue Mar 12, 2019 · 9 comments

Comments

@dra27
Copy link
Member

dra27 commented Mar 12, 2019

Note ocaml/opam-repository#12674 which is blocked only by a CI issue and once that's fixed will be wanted. Can we pick a higher initial release number - is there anything prevent 5.0?

@dra27
Copy link
Member Author

dra27 commented Mar 12, 2019

Or 4.09.0, for that matter 🙂

@ghost
Copy link

ghost commented Mar 12, 2019

That seems fine to me. Thinking about it again, we should probably not make this package available for OCaml < 4.09, otherwise there will be a conflict for the ownership of file graphics/META, i.e. both ocamlfind and this package might try to install it :/

@dra27
Copy link
Member Author

dra27 commented Mar 12, 2019

Indeed - but once that opam-repository PR is sorted, the package becomes uniformly installable with opam install graphics, so that seems OK!

@ghost
Copy link

ghost commented Mar 13, 2019

It's just that we have a problem if we install things in this order:

  1. ocaml < 4.09
  2. ocamlfind
  3. graphics (this repo)

in this case, ocaml will install <stdlib-dir>/graphics.cma. Because of this, ocamlfind will install <libdir>/graphics/META. graphics will also install <libdir>/graphics/META because that's what it always does: BOOM.

It feels safer to simply wait for 4.09 and release this repo with a >= 4.09 lower bound.

@dra27
Copy link
Member Author

dra27 commented Mar 13, 2019

I agree - all I meant was to release with a version number that's definitely bigger than the graphics.4.08.0 which will hopefully by then be in opam-repository.

@dra27
Copy link
Member Author

dra27 commented Mar 14, 2019

The opam-repository PR is merged. As it happens, you can build later versions of graphics with older compilers (I seem to remember finding that OCaml 3.07 could actually compile the 4.06.0 graphics library!) but for opam-repository I elected to have it that you always get the version of graphics which matches the compiler, just for the "least surprise" principle.

So when 4.08.0 is released, I'll do an update on opam-repository for graphics.4.08.0 and then when 4.09.0 comes out we can release this package as graphics.4.09.0 with the an ocaml >= "4.09.0" constaint.

@ghost
Copy link

ghost commented Mar 14, 2019

That works for me!

@ghost
Copy link

ghost commented Mar 14, 2019

I updated the changelog to be sure to use the right number when release time comes

@xavierleroy
Copy link
Contributor

The latest release is numbered 5.0.0, so I guess this report served its purpose and can be closed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants