Lift the restriction that external identifiers must be functions #568

Closed
chenglou opened this Issue Sep 1, 2016 · 2 comments

Projects

None yet

3 participants

@chenglou
chenglou commented Sep 1, 2016

cc @bobzhang

In BuckleScript the FFI might be like this:

external foo: document = "document" [@@bs.val]

Merlin warns on the first document that identifier must be a function. Is it possible to relax this requirement?

@bobzhang
Member
bobzhang commented Sep 1, 2016

the patch we applied:
bloomberg/ocaml@20146da#diff-aa5ff89b777ddc4932a276703533682aL1327
basically if the external is annotated with bs, we loose such restriction

@let-def
Contributor
let-def commented Sep 6, 2016

This seems minor, we relaxed the check in latest version.

@let-def let-def closed this Sep 6, 2016
@bobzhang bobzhang referenced this issue in bloomberg/bucklescript Sep 30, 2016
Closed

Merlin ppx errors #815

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment