Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Specify license, make original ocaml code explicit #8

Closed
let-def opened this Issue Feb 20, 2013 · 3 comments

Comments

Projects
None yet
3 participants
Contributor

let-def commented Feb 20, 2013

I am thinking of MIT license. However now that I am not the only author, your advice and opinions are welcome :).

Also, it would be really nice to clarify license of original Ocaml code and satisfy QPL2 requirements. What should be done in this respect ?

Member

gasche commented Feb 20, 2013

I'm not a lawyer but my understanding of the QPL (version 1.0, by the way) requirement that you distribute modifications "in a form that is separate from the Software" is that it is satisfying to have an orig/ subdirectory that contains the original of the source files you've modified, and be explicit in your files that partially reuse original code to mark it as coming from the compiler sources.

As far as license is concerned, I have a personal preference for copyleft licenses so would suggest LGPL in this case (GPL adds the additional constraints that editor modes must also be placed under GPL, not just modifications to the merlin code itself (or existing copyleft editor modes); I understand that if you want to encourage people to develop editor modes on top of merlin, leaving them licensing freedom is a good choice). I haven't written any code for merlin (yet) so you shouldn't take that into consideration too much. MIT and BSD licences are also fine.

(If you allow the snark, you should probably have specified a license as soon as you got your first external contribution in.)

Contributor

trefis commented Feb 20, 2013

I don't know anything about the QPL licence, so I won't add anything on that topic.

For the licence however I'm not so fond of the (L)GPL, so that would be a no for me. But I'm fine with any MIT or BSD licence (one I have used in the past is the ISC licence).

Contributor

let-def commented Feb 20, 2013

6b47aaf add the orig directory and tries to clarify Ocaml licensing.
Does it look good enough to you @gasche?

@let-def let-def closed this Feb 20, 2013

let-def added a commit that referenced this issue Feb 20, 2013

[#8] Added LICENSE_MIT.txt
Whole work licensed under MIT license :).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment