Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emacs: no conf caching #1018

Merged
merged 2 commits into from Sep 17, 2019

Conversation

@trefis
Copy link
Contributor

commented Sep 11, 2019

It is possible for the config to change independently from the buffer (because the external environment changed), in such situations, the user currently has to manually clear the cache to get back into a working state.

This PR offers a way to prevent the config from being cached, enforcing that the grouping function is called on every request.
(In an ideal setup, the grouping function does its own caching and is aware of environment changes).

Requested by @m-plamann.

@Wilfred

This comment has been minimized.

Copy link
Contributor

commented Sep 12, 2019

The code seems reasonable, but is the performance benefit of caching the config noticeable? Does it make sense to cache at all?

@trefis

This comment has been minimized.

Copy link
Contributor Author

commented Sep 12, 2019

Yes. At Jane Street the "merlin-grouping" function calls out to a script that lives on nfs. That introduces a noticeable latency.
Of course we could just say that the caching is always done by the provider of the grouping function, and that merlin never bothers to do it.

I'm not sure if that would also impact the "regular" setup with merlin coming from opam etc. (i.e. I haven't looked).

@trefis trefis merged commit 42c3714 into master Sep 17, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@trefis trefis deleted the emacs-no-conf-caching branch Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.