From db4749a56d1ef85234681eb55480848df4e12a25 Mon Sep 17 00:00:00 2001 From: Lucccyo Date: Tue, 25 Nov 2025 10:48:16 +0100 Subject: [PATCH 1/2] Add cram test to reproduce the issue --- .../signature-help/issue_let_in_binding.t | 20 +++++++++++++++++++ 1 file changed, 20 insertions(+) create mode 100644 tests/test-dirs/signature-help/issue_let_in_binding.t diff --git a/tests/test-dirs/signature-help/issue_let_in_binding.t b/tests/test-dirs/signature-help/issue_let_in_binding.t new file mode 100644 index 0000000000..77b9999ae9 --- /dev/null +++ b/tests/test-dirs/signature-help/issue_let_in_binding.t @@ -0,0 +1,20 @@ + $ cat > test1.ml <<'EOF' + > let _ = + > let f = List.map in + > let _ = 5 in + > 7 + > EOF + + $ $MERLIN single signature-help -position 2:17 -filename test1 < test1.ml | jq '.value.signatures[0].label' + "List.map : ('a -> 'b) -> 'a list -> 'b list" + +FIXME: Signature-help does not trigger on unfinished let ... in bindings. + $ cat > test2.ml <<'EOF' + > let _ = + > let f = List.map + > let _ = 5 in + > 7 + > EOF + + $ $MERLIN single signature-help -position 2:17 -filename test2 < test2.ml | jq '.value.signatures[0].label' + null From a309fdc469e26b058cf17045214314de62bc419e Mon Sep 17 00:00:00 2001 From: Lucccyo Date: Mon, 8 Dec 2025 09:43:51 +0100 Subject: [PATCH 2/2] Update Changelog --- CHANGES.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGES.md b/CHANGES.md index 82f439ebf7..6825278c25 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -7,6 +7,7 @@ unreleased - Stop unnecessarily forcing substitutions when initializing short-paths graph (#1988) + test suite - Add a test to ensure the behavior showed in issue #1517 is no longer relevant (#1995) + - Signature-help should trigger on unfinished `let ... in` bindings (#2009) merlin 5.6 ==========