New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use colons rather than asterisks for Vim names #677

Merged
merged 1 commit into from Jul 22, 2017

Conversation

Projects
None yet
2 participants
@dra27
Contributor

dra27 commented Jul 21, 2017

Internal buffer names are wrapped with asterisks which causes problems on Vim for Windows since it causes the filename globber to be invoked. Using colons works (and also has the benefit of creating an illegal filename, rather than one which is simply unlikely).

Without this change, the call to bot split *merlin-type-history* in merlin_type.vim causes an error message and the user's buffer gets the type information instead.

Use colons rather than asterisks for Vim names
Internal buffer names are wrapped with asterisks which causes problems
on Vim for Windows since it causes the filename globber to be invoked.
Using colons works (and also has the benefit of creating an illegal
filename, rather than one which is simply unlikely).

Signed-off-by: David Allsopp <david.allsopp@metastack.com>

@trefis trefis merged commit 048ccad into ocaml:master Jul 22, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@trefis

This comment has been minimized.

Contributor

trefis commented Jul 22, 2017

Thanks!

@dra27 dra27 deleted the dra27:fix-vim-windows branch Jul 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment