New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix `\r` problems on recent Cygwins #682

Merged
merged 1 commit into from Jul 26, 2017

Conversation

Projects
None yet
2 participants
@dra27
Contributor

dra27 commented Jul 25, 2017

The Cygwin packages for awk, grep and sed were updated on 20 February 2017 so that they no longer automatically strip \r characters on binary mounts. Add tr calls in various places in configure to get rid of them.

This also fixes the findlib version test, which would never have worked.

References:

Fix \r problems on recent Cygwins
The Cygwin packages for awk, grep and sed were updated on 20 February
2017 so that they no longer automatically strip \r characters on binary
mounts. Add tr calls in various places in configure to get rid of them.

This also fixes the findlib version test, which would never have worked.

References:
  * https://cygwin.com/ml/cygwin/2017-02/msg00152.html
  * https://cygwin.com/ml/cygwin/2017-02/msg00189.html
  * https://cygwin.com/ml/cygwin/2017-02/msg00188.html

Signed-off-by: David Allsopp <david.allsopp@metastack.com>
@dra27

This comment has been minimized.

Contributor

dra27 commented Jul 25, 2017

This patch allows 2.5.5 to compile on Windows with OCaml 4.04.2

@let-def let-def merged commit c4d8262 into ocaml:master Jul 26, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dra27 dra27 deleted the dra27:fix-newer-cygwin branch Jul 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment