Fix \r problems on recent Cygwins
#682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Cygwin packages for awk, grep and sed were updated on 20 February 2017 so that they no longer automatically strip \r characters on binary mounts. Add tr calls in various places in configure to get rid of them. This also fixes the findlib version test, which would never have worked. References: * https://cygwin.com/ml/cygwin/2017-02/msg00152.html * https://cygwin.com/ml/cygwin/2017-02/msg00189.html * https://cygwin.com/ml/cygwin/2017-02/msg00188.html Signed-off-by: David Allsopp <david.allsopp@metastack.com>
|
This patch allows 2.5.5 to compile on Windows with OCaml 4.04.2 |
This was referenced Aug 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Cygwin packages for awk, grep and sed were updated on 20 February 2017 so that they no longer automatically strip
\rcharacters on binary mounts. Addtrcalls in various places in configure to get rid of them.This also fixes the findlib version test, which would never have worked.
References: