Add Best Known Methods #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add a link to the Lists tutorial in the index page * Replace template variable in markdown
patricoferris
pushed a commit
to patricoferris/v3.ocaml.org-server
that referenced
this pull request
Sep 22, 2021
patricoferris
approved these changes
Sep 22, 2021
| @@ -140,7 +140,7 @@ val hello : unit -> unit | |||
|
|
|||
| (note the double asterisk at the beginning of the comment - it is a good habit | |||
| to document .mli files using the format supported by | |||
| [ocamldoc](/releases/{{! get LATEST_OCAML_VERSION_MAIN !}}/htmlman/ocamldoc.html)) | |||
| [ocamldoc](/releases/4.12.0/htmlman/ocamldoc.html)) | |||
There was a problem hiding this comment.
I'm guessing once we have releases we could point this to /releases/latest which redirects to the latest release we have?
Co-authored-by: Patrick Ferris <pf341@patricoferris.com>
Co-authored-by: Patrick Ferris <pf341@patricoferris.com>
Co-authored-by: Patrick Ferris <pf341@patricoferris.com>
Co-authored-by: Patrick Ferris <pf341@patricoferris.com>
Co-authored-by: Patrick Ferris <pf341@patricoferris.com>
Co-authored-by: Patrick Ferris <pf341@patricoferris.com>
Co-authored-by: Patrick Ferris <pf341@patricoferris.com>
Co-authored-by: Patrick Ferris <pf341@patricoferris.com>
Co-authored-by: Patrick Ferris <pf341@patricoferris.com>
Co-authored-by: Patrick Ferris <pf341@patricoferris.com>
Co-authored-by: Patrick Ferris <pf341@patricoferris.com>
Co-authored-by: Patrick Ferris <pf341@patricoferris.com>
Co-authored-by: Patrick Ferris <pf341@patricoferris.com>
Co-authored-by: Patrick Ferris <pf341@patricoferris.com>
Co-authored-by: Patrick Ferris <pf341@patricoferris.com>
Co-authored-by: Patrick Ferris <pf341@patricoferris.com>
Co-authored-by: Patrick Ferris <pf341@patricoferris.com>
Co-authored-by: Patrick Ferris <pf341@patricoferris.com>
Co-authored-by: Patrick Ferris <pf341@patricoferris.com>
Co-authored-by: Patrick Ferris <pf341@patricoferris.com>
Co-authored-by: Patrick Ferris <pf341@patricoferris.com>
Co-authored-by: Patrick Ferris <pf341@patricoferris.com>
Co-authored-by: Patrick Ferris <pf341@patricoferris.com>
Co-authored-by: Patrick Ferris <pf341@patricoferris.com>
|
Thanks a lot for the thorough review @patricoferris!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Best Known Methods data and includes them on the Best Practices page.
The design is not final, I'll work on this in a follow-up PR.