Implement darkmode on Learn/Platform Tools page #1896
Conversation
…mponents to use already created reusable component (footer_icon_link)
… to use already created re-usable component (package_card)
|
Hey @oyenuga17, there's a lot of conflicts here, I suppose you didn't want to include all those commits in the PR. The only relevant one seems to be 1f2093c. The way to tidy this up: make a copy of your branch, then go back to this PR branch. |
- implement header dark mode
- add missing tailwind colors - use new tailwind color names for light and dark mode
oyenuga17
force-pushed
the
outreachy-task-3
branch
from
1f2093c
to
c640617
Compare
| @@ -88,14 +88,14 @@ let sidebar | |||
| <%s t %> | |||
| </span> | |||
| in | |||
| <a class="border-l-2 py-2 px-3 rounded-sm leading-6 <%s if current then {|font-bold text-primary bg-legacy-primary-100 border-primary|} else {|text-legacy-default hover:bg-gray-100 border-transparent|} %>" href="<%s href %>"> | |||
| <a class="border-l-2 py-2 px-3 rounded-sm leading-6 font-normal <%s if current then {|text-title dark:text-dark-title bg-primary_nav_block_hover_10 dark:bg-primary_nav_block_hover_10 border-primary dark:border-dark-primary|} else {|text-content dark:text-dark-content hover:text-primary dark:hover:text-dark-primary border-transparent|} %>" href="<%s href %>"> | |||
There was a problem hiding this comment.
It has the same background for light and dark mode.
There was a problem hiding this comment.
Hi @SaySayo, they both have the same color according to the design
src/ocamlorg_frontend/pages/home.eml
Outdated
| @@ -353,7 +353,7 @@ Layout.render | |||
| <div class="flex flex-col lg:flex-row justify-between lg:space-x-20 space-y-10 lg:space-y-0"> | |||
| <div class="shadow-lg p-10 bg-legacy-default dark:bg-legacy-dark-default rounded-xl lg:mb-0"> | |||
There was a problem hiding this comment.
| <div class="shadow-lg p-10 bg-legacy-default dark:bg-legacy-dark-default rounded-xl lg:mb-0"> | |
| <div class="shadow-lg p-10 bg-white dark:bg-dark-background rounded-xl lg:mb-0"> |
There was a problem hiding this comment.
@SaySayo I think I added this changes by mistake. I'll discard the changes I made to this file for now and create a separate pr for this page when there's a design for it.
src/ocamlorg_frontend/pages/home.eml
Outdated
| @@ -156,7 +156,7 @@ Layout.render | |||
| </div> | |||
| <div class="text-legacy-default font-bold">Powerful Type Safety Made Simple</div> | |||
There was a problem hiding this comment.
| <div class="text-legacy-default font-bold">Powerful Type Safety Made Simple</div> | |
| <div class="text-content dark:text-dark-content font-bold">Powerful Type Safety Made Simple</div> |
src/ocamlorg_frontend/pages/home.eml
Outdated
| @@ -370,7 +370,7 @@ Layout.render | |||
| </div> | |||
| <div class="shadow-lg p-10 bg-legacy-default dark:bg-legacy-dark-default rounded-xl"> | |||
There was a problem hiding this comment.
| <div class="shadow-lg p-10 bg-legacy-default dark:bg-legacy-dark-default rounded-xl"> | |
| <div class="shadow-lg p-10 bg-white dark:bg-dark-background rounded-xl"> |
| @@ -1,4 +1,4 @@ | |||
| let render | |||
| let render | |||
There was a problem hiding this comment.
Take out unnecessary white space
src/ocamlorg_frontend/pages/home.eml
Outdated
| @@ -182,7 +182,7 @@ Layout.render | |||
| <h3 class="text-legacy-default font-bold"> | |||
There was a problem hiding this comment.
| <h3 class="text-legacy-default font-bold"> | |
| <h3 class="text-content dark:text-dark-content font-bold"> |
|
Check out the suggested changes @oyenuga17 |
|
closing this for now, will re-open when #1913 is merged |
@SaySayo @punchagan please help review